Repository navigation
Apply instance name rules when renaming an instance - #9127
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9127 +/- ##
=======================================
Coverage 80.03% 80.03%
=======================================
Files 476 476
Lines 26212 26216 +4
Branches 6981 6982 +1
=======================================
+ Hits 20979 20983 +4
Misses 5233 5233
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andypalmi
approved these changes
Nov 9, 2026
andypalmi
left a comment
andypalmi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, two small nits inline.
Co-authored-by: Andrea Palmieri <76187074+andypalmi@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renaming an instance through the update endpoint now uses the same name rules as creating one. Names that would be rejected at create are now rejected on rename with the same
invalid_project_nameerror.Updates two existing rename tests that used names with spaces, and adds a test for invalid names.
Related Issue(s)
Resolves https://github.com/FlowFuse/security/issues/188
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel